Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add preliminary labels to queries [VS-381] #7902

Merged
merged 12 commits into from
Jun 17, 2022
Merged

Add preliminary labels to queries [VS-381] #7902

merged 12 commits into from
Jun 17, 2022

Conversation

rsasch
Copy link

@rsasch rsasch commented Jun 14, 2022 •
edited
Loading

Label names are standard from https://docs.google.com/document/d/1eyPrpCSCMyf1CaBkc-aDi39xV7Bq9hthh07ludpgPNw

branch adds labels to:

  • bg query calls in WDL command blocks
  • queries run within python scripts called by WDLs
  • datasets created with Utils.BuildGATKJarAndCreateDataset

Quickstart integration run here: https://app.terra.bio/#workspaces/gvs-dev/GVS%20Integration/job_history/15442e08-92af-48bc-ab96-2bdd4f39a801

mcovarr
mcovarr reviewed Jun 14, 2022
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming that's a mangy typo, otherwise please ignore...

OOC any reason not to use underscores in the core workflow names to improve readability?

scripts/variantstore/wdl/GvsAssignIds.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsCreateAltAllele.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsCreateAltAllele.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsExtractCallset.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsExtractCallset.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsImportGenomes.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/GvsImportGenomes.wdl Outdated Show resolved Hide resolved
scripts/variantstore/wdl/extract/create_ranges_cohort_extract_data_table.py Outdated Show resolved Hide resolved
scripts/variantstore/wdl/extract/populate_alt_allele_table.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (ah_var_store@89a7d5d). Click here to learn what that means.
The diff coverage is n/a.

@@               Coverage Diff                @@
##             ah_var_store     #7902   +/-   ##
================================================
  Coverage                ?   86.289%           
  Complexity              ?     35190           
================================================
  Files                   ?      2170           
  Lines                   ?    164888           
  Branches                ?     17786           
================================================
  Hits                    ?    142280           
  Misses                  ?     16283           
  Partials                ?      6325

@rsasch
Copy link
Author

rsasch commented Jun 14, 2022

I'm assuming that's a mangy typo, otherwise please ignore...

Indeed — thanks for catching that!

OOC any reason not to use underscores in the core workflow names to improve readability?

Nope, done

@rsasch rsasch requested a review from mcovarr June 15, 2022 12:39
mcovarr
mcovarr approved these changes Jun 15, 2022
View reviewed changes
Copy link
Collaborator

@mcovarr mcovarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rsasch rsasch requested a review from RoriCremer June 16, 2022 14:01
kcibul
kcibul approved these changes Jun 17, 2022
View reviewed changes
Copy link
Contributor

@kcibul kcibul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- we'll need to make similar changes to the Java code where we execute queries, but as I understand that's for a future PR

@rsasch rsasch merged commit 00f07e9 into ah_var_store Jun 17, 2022
@rsasch rsasch deleted the rsa_add_prelim_labels branch June 17, 2022 14:45
RoriCremer pushed a commit that referenced this pull request Jun 29, 2022
@rsasch @RoriCremer
Add preliminary labels to queries [VS-381] (#7902)
91d5e96
This was referenced Mar 17, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcovarr mcovarr mcovarr approved these changes

@kcibul kcibul kcibul approved these changes

@RoriCremer RoriCremer Awaiting requested review from RoriCremer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rsasch @kcibul @RoriCremer @mcovarr